Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Column width based on the layout selected. #16302

Closed
phpbits opened this issue Jun 26, 2019 · 2 comments
Closed

Set Column width based on the layout selected. #16302

phpbits opened this issue Jun 26, 2019 · 2 comments
Labels
[Block] Columns Affects the Columns Block [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@phpbits
Copy link
Contributor

phpbits commented Jun 26, 2019

Describe the bug
Column width is still empty and displaying bordered warning.

To reproduce
Steps to reproduce the behavior:

  1. Insert Column block and select a column

Expected behavior
Width should be set based on the selected column layout.

Screenshots
Screen Shot 2019-06-26 at 9 30 55 PM

@aduth
Copy link
Member

aduth commented Jun 26, 2019

It is intended that there not be an explicit assigned value for the width, when choosing a template for one of the equal column widths, since the default behavior of the columns block is to distribute widths evenly. This was a later change in #16129 (#16129 (comment)).

I'm not able to reproduce the issue with the warning border. Were there other steps before this was shown? An incompatibility with a theme or plugin?

@aduth aduth added [Block] Columns Affects the Columns Block [Status] Needs More Info Follow-up required in order to be actionable. labels Jun 26, 2019
@phpbits
Copy link
Contributor Author

phpbits commented Jun 26, 2019

An incompatibility with a theme or plugin?

Oh yeah! Just checked and the CSS is coming from Block Lab. My bad. Thanks!

@phpbits phpbits closed this as completed Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

2 participants