Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Group block contents to toggle between "centered" and "full-width" mode. #16197

Closed
kjellr opened this issue Jun 17, 2019 · 3 comments
Closed
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.

Comments

@kjellr
Copy link
Contributor

kjellr commented Jun 17, 2019

Following up from #15210.

  • Add a "centered column" toolbar control (possibly using this icon). This will be on by default.
  • When this control is off, we'll remove (or ignore) the inner div from the Group block.
  • When this control is off, we'll also disable all wide/full controls for child blocks. All children of the group block will take up all available horizontal space within the group block.

"Centered column" is turned on:

"Centered Column" is turned off:

@kjellr kjellr added [Type] Enhancement A suggestion for improvement. [Block] Group Affects the Group Block labels Jun 17, 2019
@draganescu
Copy link
Contributor

Hi @kjellr isn't this the same as the current wide/full setting on the Group block. The example in the second picture above can be achieved with setting the group to full and a cover to full.

@kjellr
Copy link
Contributor Author

kjellr commented Apr 23, 2020

Sort of. I think the goal of this was actually to have a setting so that even interior blocks without wide/full options (like a paragraph for example) would still take up the full width in there.

But that said, I think there are a bunch of potential ways around this. I'm not totally sure it makes sense to keep this open for now.

@draganescu
Copy link
Contributor

In this case I'll close it and we can reopen at any time :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants
@draganescu @kjellr and others