Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better scope CSS changes after #14407 to avoid plugins layout breakage #15465

Closed
afercia opened this issue May 6, 2019 · 0 comments · Fixed by #16207
Closed

Better scope CSS changes after #14407 to avoid plugins layout breakage #15465

afercia opened this issue May 6, 2019 · 0 comments · Fixed by #16207
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@afercia
Copy link
Contributor

afercia commented May 6, 2019

#14407 introduced some CSS changes that can break the UI provided by plugins.

Specifically the margins applied using the [data-block] selector, is breaking something in the Yoast SEO metabox and can potentially break other plugins. The Yoast SEO metabox uses some editable fields generated by Draft.js, which does use a data-block="true" attribute.

Broken layout:

Screenshot 2019-05-06 at 17 13 13

Previous (and expected) layout:

Screenshot 2019-05-06 at 17 13 32

Can this change be revisited please? This selector is too broad, not scoped with any specific Gutenberg class and, at the very least, should be restricted to only the editor content area.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant