Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NUX: Customize aria-label #12631

Closed
TimothyBJacobs opened this issue Dec 6, 2018 · 3 comments
Closed

NUX: Customize aria-label #12631

TimothyBJacobs opened this issue Dec 6, 2018 · 3 comments
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Enhancement A suggestion for improvement.

Comments

@TimothyBJacobs
Copy link
Member

Is your feature request related to a problem? Please describe.
In master the NUX <DotTip> component has an aria-label set to "Editor Tips". This only makes sense when using the nux package in the editor.

Describe the solution you'd like
Allow overriding the aria-label or use a more generic message like "Interface Tips" or something.
@designsimply
Copy link
Member

May I make the argument that, even if <DotTip> were to be used outside of editing posts, that you would still be editing and the "Editor Tips" label may still apply? Or if I'm thinking of it wrong 🤔 could you tell me a specific use case where you would definitely not want the label to say "Editor Tips" (or maybe a slight change to "Editing Tips")?

@designsimply designsimply added the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 6, 2018
@TimothyBJacobs
Copy link
Member Author

Yep. It has nothing to do with editing or content at all. It's a completely separate admin experience. Imagine a <DotTip> being used in the General Settings page for instance. It'd make no sense to reference the editor or even editing in that context.

@designsimply designsimply added [Type] Enhancement A suggestion for improvement. [Feature] NUX Anything that impacts the new user experience and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Dec 19, 2018
@noisysocks
Copy link
Member

Closing this out as tips have been removed in #18041 and DotTip has been deprecated in #18981.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] NUX Anything that impacts the new user experience [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@noisysocks @designsimply @TimothyBJacobs