Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalinks to the document sidebar #11858

Closed
karmatosed opened this issue Nov 14, 2018 · 8 comments · Fixed by #11874
Closed

Add permalinks to the document sidebar #11858

karmatosed opened this issue Nov 14, 2018 · 8 comments · Fixed by #11874
Assignees
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts

Comments

@karmatosed
Copy link
Member

The current problem is permalinks aren't that discoverable. This has been reported in feedback. Right now, the title on select show the permalink. In phase 2 this likely won't be a case moving into everything being a block, so changing now is important.

@melchoyce worked on a suggested design for this which adds to the document settings (note this adds doesn't remove from title for now):

link-settings

  • On select of title won't be changing, it will still show permalink.
  • Publishing flow will still show permalink.
  • This is a new panel to be added to document settings.

This ideally would be added before 5.0 as really could help people now. It is based on the existing pattern in the publishing flow, which means it should be easier to implement.

One feature that may want to be added is the ability to copy the link from here easily.

As time is of the essence having this move into a PR would be great to get a feel of this.

@karmatosed karmatosed added Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts labels Nov 14, 2018
@karmatosed karmatosed added this to the 4.4 milestone Nov 14, 2018
@gziolo
Copy link
Member

gziolo commented Nov 14, 2018

What about custom post types? Should it be included, too? I'm asking because it contains distinction between page and post.

@jorgefilipecosta
Copy link
Member

What about custom post types? Should it be included, too? I'm asking because it contains distinction between page and post.

My plan is to use the singular CPT label, so it will "Post Link", "Page Link", "Book Link", "Movie Link" etc...

@jorgefilipecosta jorgefilipecosta self-assigned this Nov 14, 2018
@mtias
Copy link
Member

mtias commented Nov 14, 2018

Yes, should use the provided and localized CPT label.

@alexislloyd
Copy link
Contributor

I really like this solution as it makes the permalink settings more discoverable. The "preview" link below the field also clearly shows the output of the setting for users.

@chrisvanpatten
Copy link
Contributor

Should the label be "Post Slug" since it's not actually showing the full URL?

Overall I think this is a great improvement. I'm not sure whether exposing permalink settings there is necessary but unless there's strong consensus one way or the other I'll go with the group :)

@jwold
Copy link

jwold commented Nov 15, 2018

Love this proposed change. Permalinks have been a bit hard for me to work with.

What happens when I click “permalink settings”?

@melchoyce
Copy link
Contributor

Should the label be "Post Slug" since it's not actually showing the full URL?

"Slug" isn't a super friendly term for non-technical folks. I reviewed Wix, Weebly, and Squarespace, and they all use some form of "URL," even though you're just editing the slug.

What happens when I click “permalink settings”?

Takes you to options-permalink.php.

@youknowriad youknowriad modified the milestones: 4.4, 4.5 Nov 15, 2018
@mtias mtias modified the milestones: 4.5, WordPress 5.0 RC Nov 15, 2018
jorgefilipecosta added a commit that referenced this issue Nov 15, 2018
## Description
Closes: #11858
This PR adds a permalink panel to the document sidebar, trying to follow the design specified in #11858.

This PR is the first iteration so that we can iterate on the design in parallel.
One missing nice feature is the ability to auto refresh the permalink settings (prefix/suffix) if the settings are changed in another tab, I'm not sure if this feature is a blocker and I wanted to think a little bit better about this part.


## How has this been tested?
Verify that if the post is new, the panel does not appear. Some behavior we have on the existing permalink edit UI (close to title).
Verify that if the post does not contains editable permalinks (e.g.: Plain permalink setting) the input is not available and only the post link is shown.
Verify that if the permalink is editable it is possible to edit the permalink without problems and after saving the post the permalink is correctly changed/saved.

## Screenshots <!-- if applicable -->

<img width="281" alt="screenshot 2018-11-14 at 17 57 30" src="https://user-images.githubusercontent.com/11271197/48504970-ea847b00-e83d-11e8-8c19-484c7007b67c.png">
<img width="277" alt="screenshot 2018-11-14 at 18 19 20" src="https://user-images.githubusercontent.com/11271197/48504971-ea847b00-e83d-11e8-87f5-37d62da62203.png">
<img width="285" alt="screenshot 2018-11-14 at 18 45 37" src="https://user-images.githubusercontent.com/11271197/48504972-eb1d1180-e83d-11e8-82fa-087666d8b6c6.png">
@jasonbahl
Copy link

If the permalink is moved to the document sidebar, can the title be as well? When trying to build a wysiwyg experience, many times the title is not the first thing on the page, so you end up with a not-so-wysiwyg experience because you have a title above the content but it appears as if it’s part of the content and it’s just confusing from a wysiwyg standpoint.

The title should be a property of the document, and should be able to be placed in the page where it makes sense to be placed, often below images or carousels or other leading elements.

Sometimes the title isn’t even displayed on the front end at all.

Let the document properties be document properties and the editor be for editing.

Discussed here back in April too.
https://github.com/WordPress/gutenberg/issues/4482#issuecomment-382809415‬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Design Feedback Needs general design feedback. Needs Dev Ready for, and needs developer efforts
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants