Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: tip dot overlays menu flyout #11563

Closed
drawcard opened this issue Nov 7, 2018 · 8 comments
Closed

UX: tip dot overlays menu flyout #11563

drawcard opened this issue Nov 7, 2018 · 8 comments
Labels
[Feature] NUX Anything that impacts the new user experience Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@drawcard
Copy link

drawcard commented Nov 7, 2018

Describe the bug
The tip dot z-index is too high and overlaps menu item flyout

To Reproduce
Nil

Expected behavior
The tip dot should sit below the menu item flyout

Screenshots
If applicable, add screenshots to help explain your problem.
image

Desktop (please complete the following information):

  • OS: macOS Mojave 10.14.0
  • Browser: Chrome 70.0.3538.77

Relevant code:

// Show NUX tips above popovers, wp-admin menus, submenus, and sidebar:
".nux-dot-tip": 1000001,

@designsimply
Copy link
Member

I am not sure what the expected behavior is for this. Is it okay to have the tip above a menu item since it is dismissible?

@designsimply designsimply added the Needs Design Feedback Needs general design feedback. label Nov 7, 2018
@drawcard
Copy link
Author

drawcard commented Nov 8, 2018

To me I find it a bit confusing, I would expect that all tips (including the dot and dialog box) sit below any critical UI rather than above it.

In fact I discovered this randomly by firing up a new post in a fresh install of WP5, and then making a decision to do something elsewhere in WP - wherein I noticed the flyout was obscured by the dot / dialog box. It felt a bit broken / unpolished to me, and not what I expected.

@designsimply
Copy link
Member

Thanks for posting a specific use case. Always helpful to have that. It would be cool to get some additional input so I’ll leave this open for feedback for now.

@melchoyce
Copy link
Contributor

Yeah, weird z-index issue. I agree that the navigation menus should be higher than the tips — the tips are part of the page, and the page appears underneath the menu. Having the tips appear over the menu makes for a weird sandwich.

@drawcard
Copy link
Author

Yep I think dropping the tip's z-index down 1 unit below the menu system would do the trick.

I also wonder if other menu overlays are affected (eg 3rd party plugin menu dropdowns potentially placed in the top admin bar). This was just a blank WP5 setup I was testing out.

@mtias mtias added [Feature] NUX Anything that impacts the new user experience Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later and removed Needs Design Feedback Needs general design feedback. labels Nov 30, 2018
@youknowriad youknowriad removed this from the WordPress 5.0.3 milestone Dec 18, 2018
@Naerriel
Copy link
Contributor

Z-index goes currently like this:
admin menu < admin bar < nux dot tip

We want to keep admin menu below admin bar, because admin bar's submenus should be on top of menu:
image

Also we want to keep admin bar's z-index below nux dot tip, because it's often placed on admin bar:
image

With those dependencies it seems impossible to achieve:
admin menu > nux dot tip,
nux dot tip > admin bar,
admin bar > admin menu,
but maybe there is a workaround.

What do you think about that?

@designsimply designsimply added the Needs Design Feedback Needs general design feedback. label Jan 17, 2019
@mapk
Copy link
Contributor

mapk commented Apr 5, 2019

When changing .components-popover:not(.is-mobile).is-bottom from z-index: 99990 to z-index: 100 it seems to work just fine. However there's now a problem with the "Content Structure" toolbar popover. It normally extends further over the wp-admin navigation, so in this case part of it gets lost.

If we make this change, we'd also need to update that popover to position within Gutenberg only.

Example at z-index: 100

popover

@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Apr 10, 2019
@mapk mapk removed the Needs Design Feedback Needs general design feedback. label Jun 11, 2019
@mapk
Copy link
Contributor

mapk commented Aug 12, 2019

I'm closing this due to the new tip explorations here: #16592

Tips are being completely redesigned and these popovers will become obsolete.

@mapk mapk closed this as completed Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] NUX Anything that impacts the new user experience Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

10 participants