-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: tip dot overlays menu flyout #11563
Comments
I am not sure what the expected behavior is for this. Is it okay to have the tip above a menu item since it is dismissible? |
To me I find it a bit confusing, I would expect that all tips (including the dot and dialog box) sit below any critical UI rather than above it. In fact I discovered this randomly by firing up a new post in a fresh install of WP5, and then making a decision to do something elsewhere in WP - wherein I noticed the flyout was obscured by the dot / dialog box. It felt a bit broken / unpolished to me, and not what I expected. |
Thanks for posting a specific use case. Always helpful to have that. It would be cool to get some additional input so I’ll leave this open for feedback for now. |
Yeah, weird z-index issue. I agree that the navigation menus should be higher than the tips — the tips are part of the page, and the page appears underneath the menu. Having the tips appear over the menu makes for a weird sandwich. |
Yep I think dropping the tip's z-index down 1 unit below the menu system would do the trick. I also wonder if other menu overlays are affected (eg 3rd party plugin menu dropdowns potentially placed in the top admin bar). This was just a blank WP5 setup I was testing out. |
When changing If we make this change, we'd also need to update that popover to position within Gutenberg only. Example at |
I'm closing this due to the new tip explorations here: #16592 Tips are being completely redesigned and these popovers will become obsolete. |
Describe the bug
The tip dot z-index is too high and overlaps menu item flyout
To Reproduce
Nil
Expected behavior
The tip dot should sit below the menu item flyout
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
Relevant code:
gutenberg/assets/stylesheets/_z-index.scss
Lines 91 to 92 in 25bc46a
The text was updated successfully, but these errors were encountered: