Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block hover outline appears on another block while typing #11133

Closed
mrwweb opened this issue Oct 26, 2018 · 14 comments
Closed

Block hover outline appears on another block while typing #11133

mrwweb opened this issue Oct 26, 2018 · 14 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Milestone

Comments

@mrwweb
Copy link

mrwweb commented Oct 26, 2018

Describe the bug
This feels like a critical violation of the "just write" ethos Gutenberg hopes to achieve.

To Reproduce
When typing, hover your cursor over a different block. The outline will appear for the block you are not working on. This is especially distracting if you happen to nudge your cursor into a different block area.

Expected behavior
If I'm writing, the UI should not encourage me to look elsewhere. I also don't know what caused the formatting toolbar to briefly pop up.

Screenshots
Animated GIF showing described behavior

Desktop (please complete the following information):

  • OS: Win10
  • Browser Firefox 62.0.3
  • Version WP 5.0 beta-1
@designsimply
Copy link
Member

Adding the Needs Testing label and noting we should check whether this also happens with the 4.1.1 plugin or whether it's limited to WP 5.0 beta.

@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Oct 26, 2018
@Robertght
Copy link

I can confirm the behaviour on Gutenberg 4.1.1 with WordPress 4.9.8 as well.

OS: MacOS Mojave,
Browser: Chrome 69.0.3497.100 and Version 70.0.3538.77 (ran an update after checking the version the first time :) )

cc @designsimply

@earnjam earnjam added the [Type] Bug An existing feature does not function as intended label Oct 29, 2018
@earnjam
Copy link
Contributor

earnjam commented Oct 29, 2018

I'm going to label this as a bug. It's still occurring on the latest in WP 5.0 branch, and latest from Gutenberg master using WP 4.9.8.

The cursor is supposed to disappear when typing resumes, and it does in my testing, however the blue block hover outline still remains.

@earnjam
Copy link
Contributor

earnjam commented Oct 29, 2018

Actually, we may need some feedback from design that this wasn't on purpose before we make it actionable though.

@earnjam earnjam added Needs Design Feedback Needs general design feedback. and removed Needs Testing Needs further testing to be confirmed. labels Oct 29, 2018
@mrwweb mrwweb changed the title Block hover outline appears on another block whilte typing Block hover outline appears on another block while typing Oct 29, 2018
@mrwweb
Copy link
Author

mrwweb commented Nov 1, 2018

Running 5.0-beta2 this (and all hover outlines on paragraphs?) seem to be gone. Is that intended? Was this addressed elsewhere?

@melchoyce
Copy link
Contributor

@mrwweb It's intended in Focus mode — see #9394.

@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Nov 21, 2018
@karmatosed karmatosed removed the Needs Design Feedback Needs general design feedback. label Nov 22, 2018
@designsimply
Copy link
Member

Re-tested and confirmed using WordPress 5.1 and no plugins that the block outline and label are always on for blocks the mouse is hovered over, even if you start typing into a different block. This does appear to be the intended behavior. @mrwweb, just to check, does using Spotlight Mode which has no outlines on hover solve this issue for you? I think this is exactly the kind of thing the different modes were designed to help solve.

@mrwweb
Copy link
Author

mrwweb commented Mar 12, 2019

If that's intended behavior, then so be it. I don't like spotlight mode, so that's not a solution for me.

My overall goal is that I like to write where I can see what's before (and sometimes after) what I'm writing so that I work in context. I don't like it when those things are obscured, adorned or flashing. That's why for me, I turn on Top Toolbar but not Spotlight.

That said, sounds like this ticket isn't going anywhere so probably just worth closing? :/

@ellatrix
Copy link
Member

I keep running into the same issue:

Screenshot 2019-03-18 at 09 49 51

@melchoyce I don't think this intended behaviour? All block UI is supposed to fade away when typing starts.

@youknowriad youknowriad added this to the WordPress 5.x milestone Mar 18, 2019
@melchoyce
Copy link
Contributor

You're right — pinging @jasmussen and @kjellr in on this.

@kjellr
Copy link
Contributor

kjellr commented Mar 18, 2019

Thanks for the ping. I'd definitely be supportive of removing those hover states when the user is typing.

@designsimply designsimply added the General Interface Parts of the UI which don't fall neatly under other labels. label Apr 15, 2019
@youknowriad youknowriad added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Nov 18, 2019
@mrwweb
Copy link
Author

mrwweb commented Nov 23, 2019

Just noting that while the hover style has changed significantly since the screenshots were taken, the issue remains in WP 5.3.

@jasmussen
Copy link
Contributor

Just noting that while the hover style has changed significantly since the screenshots were taken, the issue remains in WP 5.3.

I would suggest that #17088 (which suggests to explore no hover style) and even #18667 might help finally address this one.

@ZebulanStanphill
Copy link
Member

Closing since #18862 removed the hover indicator entirely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests