Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Classic block partially overlaps the in-between lines inserter #10471

Closed
gziolo opened this issue Oct 10, 2018 · 5 comments
Closed

Classic block partially overlaps the in-between lines inserter #10471

gziolo opened this issue Oct 10, 2018 · 5 comments
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Milestone
WordPress 5.x

Comments

@gziolo
Copy link
Member

gziolo commented Oct 10, 2018 •
edited
Loading

Describe the bug

Noticed when testing #10443 and mentioned in the following comment #10443 (comment).

To Reproduce
Steps to reproduce the behavior:

  1. Create a new post.
  2. Add Classic block.
  3. Click on the previous block.
  4. Try to use in-between line inserter on the top edge of the Classic block.
  5. Inserter icon is partially hidden under Classic block's toolbar.

Expected behavior

It's always possible to use in-between lines inserter with Classic block.

Screenshots

Screen Shot 2019-04-23 at 14 22 14

Additional context

  • master branch aftr 5.5 release
@gziolo gziolo added [Type] Bug An existing feature does not function as intended [Feature] Blocks Overall functionality of blocks labels Oct 10, 2018
@gziolo
Copy link
Member Author

gziolo commented Oct 16, 2018

There is no corresponding PR, moving to 4.2.

@gziolo gziolo added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Oct 16, 2018
@youknowriad youknowriad modified the milestones: 4.2, WordPress 5.0 Oct 27, 2018
@ellatrix ellatrix added [Block] Classic Affects the Classic Editor Block and removed [Block] Classic Affects the Classic Editor Block labels Oct 31, 2018
@mtias mtias added the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label Nov 4, 2018
@burnuser burnuser mentioned this issue Nov 13, 2018
Closed
@afercia
Copy link
Contributor

afercia commented Nov 13, 2018

Related: #11345

@gziolo gziolo added the [Status] In Progress Tracking issues with work in progress label Apr 10, 2019
@gziolo gziolo removed the [Status] In Progress Tracking issues with work in progress label Apr 23, 2019
@gziolo
Copy link
Member Author

gziolo commented Apr 23, 2019 •
edited
Loading

It's better but it still needs some design tweaks:

Screen Shot 2019-04-23 at 14 22 14

In addition, I noticed that mobile experience isn't perfect, but that might be also the case for master

It's fixed now:
Screen Shot 2019-04-23 at 14 26 24

@gziolo gziolo changed the title Classic block conflicts with the in-between lines inserter Classic block partially overlaps the in-between lines inserter Apr 23, 2019
@afercia afercia removed the [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later label May 4, 2019
@afercia
Copy link
Contributor

afercia commented May 4, 2019

This still happens on current master 5.6.1, just tested again:

hover:

hover

focus:

focus

As it was originally reported almost 7 months ago, I'd like to propose to not consider this "Priority Low" any longer.

@youknowriad youknowriad mentioned this issue Aug 22, 2019
Closed
@gziolo gziolo added the Needs Dev Ready for, and needs developer efforts label Oct 21, 2019
@enriquesanchez
Copy link
Contributor

Given all the recent improvements and updates to the sibling inserter (#18941, #19456, #19596 and #11969), I believe this issue can be closed now.

Screen Shot 2020-03-16 at 13 46 31

Screen Shot 2020-03-16 at 13 49 20

@afercia afercia mentioned this issue Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Classic Affects the Classic Editor Block [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
WordPress 5.x
Development

No branches or pull requests
6 participants
@youknowriad @mtias @gziolo @afercia @enriquesanchez @ellatrix