Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard / fiddly to edit image when image is aligned with text to side, keeps selecting text not image #10332

Closed
gingerling opened this issue Oct 4, 2018 · 5 comments
Labels
[Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback. Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.

Comments

@gingerling
Copy link

Describe the bug

I am finding it hard to click on an image to edit it in some way, for example to change the size or add a caption. When an image is aligned left or right, with text wrapping it I find clicking the image selects the text blocks to the left/right rather than the image itself. I usually have to click 10 times to get the image dialogue / drag handles to show.

To Reproduce
Steps to reproduce the behavior:

  1. add an image, left align it
  2. Add text, it should sit on the right side of the left aligned image
  3. try to edit image by clicking on it repeatedly
  4. text to the right selects not image

Expected behavior
image menus and drag handles should show with first click on the image

Screenshots
https://greencloud.gn.apc.org/index.php/s/R9aJbPFY3yyF22i

Desktop (please complete the following information):

  • OS: [e.g. iOS] Fedora Linux
  • Browser [e.g. chrome, safari] Firefox
  • Version [e.g. 22] 3.9.0

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

  • Please add the version of Gutenberg you are using in the description.
  • To report a security issue, please visit the WordPress HackerOne program: https://hackerone.com/wordpress.
@designsimply designsimply added the Needs Testing Needs further testing to be confirmed. label Oct 15, 2018
@designsimply
Copy link
Member

Noting that improvements have been made on floated elements in #10085 and will show up in version 4.0. Also adding the Needs Testing label to try out and compare 3.9 vs 4.0-rc.1.

@gingerling
Copy link
Author

gingerling commented Oct 16, 2018 via email

@bahiirwa
Copy link

bahiirwa commented Nov 10, 2018

This is still happening. On alignment of images and text floating to respective side, The Images can not be resized again if you click away or are simply coming back to edit after saving changes. I found that the only way I can edit the image again is to click on the first letter of the text aligned and hitting back space. That reintroduces the drag lines to resize image. I wish the images where simply clickable and the options appear.

Testing on Desktop
OS: Windows 10
Browser: Chrome 70.0.3538.77
**Gutenberg Version: 4.2.2

@designsimply designsimply added Needs Design Feedback Needs general design feedback. [Block] Image Affects the Image Block labels Mar 1, 2019
@designsimply
Copy link
Member

@gingerling @bahiirwa since several updates to Gutenberg have been made since the latest comment was posted here, would you mind testing this again with the latest version of WordPress (you should no longer need the plugin unless you are working on developing new features or debugging) and post back here with an update?

@designsimply designsimply added the [Status] Needs More Info Follow-up required in order to be actionable. label Mar 1, 2019
@mapk
Copy link
Contributor

mapk commented Mar 8, 2019

I just tested and it appears this is resolved now, so I'll close this.

left-align-image

@mapk mapk closed this as completed Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Image Affects the Image Block Needs Design Feedback Needs general design feedback. Needs Testing Needs further testing to be confirmed. [Status] Needs More Info Follow-up required in order to be actionable.
Projects
None yet
Development

No branches or pull requests

4 participants