Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interface how components interact with each other #6

Open
vitaliimelnychuk opened this issue Dec 10, 2019 · 0 comments
Open

Add interface how components interact with each other #6

vitaliimelnychuk opened this issue Dec 10, 2019 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@vitaliimelnychuk
Copy link
Contributor

As discussed in the group meeting, there are two possible approaches.

Option 1. Develop own format for migrations; convert existing migrations wroten on Knex, Phinx, etc. into Crispy format; build internal components relying on Crispy format only. This approach will allow localizing a need for 3d party adapters to a single point - conversion of migration files. The downside is that we need to re-implement all the low-level mechanics of DB migrations.

Option 2. Develop a set of components on top of existing migrations and leveraging existing tool's binaries. This requires less overhead to migrate from existing migrations framework to Crispy, but creates maintenance overhead by supporting adapters in multiple junctions of the stack.

See the schema for both options:
IMG_0528

We decided to go with the option 1 since it's easier to start with and has a more clear roadmap.

Originally posted by @xTNTx in #5 (comment)

Based on the discussion we had there, we need better docs for crispy Components and how they interact with each other

@vitaliimelnychuk vitaliimelnychuk added the documentation Improvements or additions to documentation label Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant