Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback on week 5 project progress for willyseahh #4

Open
4 of 5 tasks
nus-se-bot opened this issue Feb 11, 2020 · 3 comments
Open
4 of 5 tasks

Feedback on week 5 project progress for willyseahh #4

nus-se-bot opened this issue Feb 11, 2020 · 3 comments

Comments

@nus-se-bot
Copy link

nus-se-bot commented Feb 11, 2020

Leftovers from the previous week

  • You are done with previous weeks work(:heavy_check_mark: well done!)

Progress of this week

  • At least 2 PRs are in your fork (:exclamation: try to do by next milestone)

  • A version tagged A-Assertions is in the repo(:heavy_check_mark: well done!)

  • A version tagged A-CodeQuality is in the repo(:heavy_check_mark: well done!)

  • A version tagged A-Travis is in the repo(:heavy_check_mark: well done!)

  • A version tagged C-Priority is in the repo(:heavy_check_mark: well done!)

Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2020-02-12 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.

@WillySeahh
Copy link
Owner

Professor sorry may I ask are we suppose to create 2 new PRs? But if i work on master for A-Assertions and Code Quality, when i push my original PR from week3 will automatically update.

Also I do not think my master branch can make more than 1 PR, in order to do that I'll have to create another branch and use that branch to PR. But the instructions did not mention about working in another branch.

@okkhoy
Copy link

okkhoy commented Feb 12, 2020

In this case, the PR should be created from a different branch to your own master not to the semester fork of duke.
Something similar to last week's task

@WillySeahh
Copy link
Owner

Prof but the instructions didnt mention that we should create a separate branch and we did not want to not do anything the instructions didn't say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants