Feedback on week 2 project progress for willyseahh

[nus-se-bot]

Progress observed

• A version tagged level-1-6 is in the repo(:heavy_check_mark: well done!)( :warning: The tag is slightly different from the expected value (Level-1). Please follow the exact tag in future )

• A version tagged Level-2 is in the repo(:exclamation: try to do by next milestone)

• A version tagged Level-3 is in the repo(:exclamation: try to do by next milestone)

• A version tagged Level-4 is in the repo(:exclamation: try to do by next milestone)

• A version tagged Level-5 is in the repo(:exclamation: try to do by next milestone)

• A version tagged Level-6 is in the repo(:heavy_check_mark: well done!)

_{Note: the above observation was done by the CS2103-feedback-bot and covers changes up to 2020-01-27 00:00:00 only. If you think the above observation is incorrect, please let us know by replying in this thread. Please include links to relevant PRs/comments in your response.}

[WillySeahh]

Hi I Have tagged Level-2 ,3,4,5. Could you check it again please?

[okkhoy]

No, you haven't!

[WillySeahh]

Prof, sorry its my first time using GitHub. But why does it appear on my side?

[okkhoy]

those look like commit messages, not tags

[WillySeahh]

oh my... but in my intellJ terminal i always followed this steps.

1. git add...
2. git commit -m "Level-2"
3. git tag "Level-2"
4. git push

git push doesn't push the tag name as well?

So sorry for the mistake Prof.. Will I be penalize for missing 2-5? I've done it... Its just I didn't know my tags did not get pushed

[okkhoy]

No, git push doesn't push tags. In sourcetree you need to select the option to push the tags. On the command line you need to push the tags explicitly.

From the textbook / module website:

and

[WillySeahh]

Oh my.. So sorry about that Prof. Do you require me to go back to my previous commit, and then re tag them and submit?

[WillySeahh]

But I am not sure of how to do the above, and am afraid that I may mess up my currently version.

I tried googling but it doesn't seem to be working.

[WillySeahh]

Alright Prof I think I've done it. I did it by:

1. git checkout "copy paste that commit 16 character unique hash"
2. tag it
3. push origin it

I did that for Level,2,3,4,5 and then i just checkout master to go back to my current Level 8.

Sorry Prof but I won't be penalized right?

[okkhoy]

You didn't have to check out. You can just use the hash to tag it in retrospect.

[WillySeahh]

Alright I see. However, when i did git checkout "hash for Level 2". My IntellJ's code did not change, in order for IntellJ to reflect the changes I need to "git pull" it so I can see the old Level 2 code right?

[okkhoy]

Probably just IntelliJ not refreshing immediately? I think it should show the changes (unless there are some conditions that I am unaware of) without having to pull

[WillySeahh]

Alright thank you Prof. Prof just to confirm we dont need to save the file in a specific format for level-7 right? Because I used java.Serialization and saved the entire arraylist into data.txt, instead of saving
deadline borrow book /by ...

[WillySeahh]

so my data.txt doesn't contain alphabets/text, its binary form of the arraylist containing the tasks

[okkhoy]

Hmmmm, this is a general question that can benefit the class. Please ask on the forums. I will not reply here 😛

[WillySeahh]

Alright, thank you!

[WillySeahh]

Prof Ashkay, can I check for my case am I considered to have met all the deliverable for week 2? I did the work, just did not push my tags...

But for the level-1-6 tag that i pushed has everything done from level 1-6

[okkhoy]

The bot will pick up the updates next time it runs.