Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the variable names in SOIT self-consistent #95

Open
danielmwatkins opened this issue Jan 10, 2024 · 2 comments
Open

Make the variable names in SOIT self-consistent #95

danielmwatkins opened this issue Jan 10, 2024 · 2 comments

Comments

@danielmwatkins
Copy link
Collaborator

SOIT expects inputs of centroid_x and centroid_y. As written, this really is centroid_lat and centroid_lon. The use of x and y here is ambiguous at best, but really is quite misleading because latitude is not an x coordinate in most map projections. I suspect but am not sure that there could be errors with some parts of the code expecting x and y to be polar stereographic and SOIT expecting latitude longitude.

It also forces lat/lon into integer, which means that the location can be nearly 100 km away from the correct centroid.

@danielmwatkins
Copy link
Collaborator Author

To add to this: I'd like to be clear throughout on the use of lat/lon versus x/y. I imagine that the best way to do this would be to have the flow generator be the place that has the if/then with the crs, translating whatever choice the user made into the terms needed in the rest of the script.

@danielmwatkins
Copy link
Collaborator Author

This has mostly been fixed - last thing is to adjust the docstring for pass times cylc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant