chore: add Git attributes for LFS #120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 7 7
Lines 215 215
=======================================
Hits 204 204
Misses 11 11 ☔ View full report in Codecov by Sentry. |
|
There might be a problem with using LFS. It seems like the org would be over quota if these files were to be added :/ |
|
It's worth a conversation to see what datasets we'd want to have as test
datasets. One approach we could take would be to use a, say, 500 or 250 km
square subset of the test images, where we are sure there are enough
detected floes for the tests to still work. That could cut the overall
dataset size by a factor of 4.
…On Fri, Mar 29, 2024 at 11:44 AM Carlos Paniagua ***@***.***> wrote:
There might be a problem with using LFS. It seems like the org would be
over quota if these files were to be added :/
—
Reply to this email directly, view it on GitHub
<#120 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB6TAUITKADOWXHZRAV6W2DY2WD57AVCNFSM6AAAAABFOSAMKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQYDGNJWGU>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
That would also have a benefit of making it faster to run the tests.
On Fri, Mar 29, 2024 at 11:54 AM Daniel Watkins ***@***.***>
wrote:
… It's worth a conversation to see what datasets we'd want to have as test
datasets. One approach we could take would be to use a, say, 500 or 250 km
square subset of the test images, where we are sure there are enough
detected floes for the tests to still work. That could cut the overall
dataset size by a factor of 4.
On Fri, Mar 29, 2024 at 11:44 AM Carlos Paniagua ***@***.***>
wrote:
> There might be a problem with using LFS. It seems like the org would be
> over quota if these files were to be added :/
>
> —
> Reply to this email directly, view it on GitHub
> <#120 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB6TAUITKADOWXHZRAV6W2DY2WD57AVCNFSM6AAAAABFOSAMKOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMRXGQYDGNJWGU>
> .
> You are receiving this because your review was requested.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will reduce the overall size of the repo. More in #119
I'll probably do this for the IFT repo as well.
Selected .png, .tiff, .dat, and .jls file types to be managed by Git LFS. These are the data file extensions used for testing. See how this is handled in the .gitattributes file.
After merging this PR, these file types will be handled by Git LFS. This means that when these files are added, committed, and pushed, they will be stored on a remote server, and text pointers will be stored in the Git repository.
Please note that to work with these large files, contributors will need to have Git LFS installed on their local machine.