Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can pipeline(), pipeline_v3(), batch(), and batch_v3() be merged to remove redundancy? #15

Open
vkirkl opened this issue Oct 31, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@vkirkl
Copy link
Collaborator

vkirkl commented Oct 31, 2024

The core work of scoutbot is done via four methods: pipeline(), pipeline_v3(), batch(), and batch_v3(), (see declarations in scoutbot/init.py). These look like they could well be reduced to as few as one method. Should we do a deeper code review and recommend a refactoring (or not)? Doing so may result in the removal of a lot of redundancy.

@vkirkl vkirkl added the enhancement New feature or request label Oct 31, 2024
@vkirkl
Copy link
Collaborator Author

vkirkl commented Nov 15, 2024

@LashaO ... would love your thoughts on this!

@LashaO
Copy link
Contributor

LashaO commented Nov 18, 2024

Hey @vkirkl This is a valid as best practice and for usability. On high level the pipelines share a lot of similarity, and were developed independently. I think there is a high chance the non-v3 methods 'pipeline' and 'batch' might be dropped or conserved as they are part of legacy code for an method model that has been since surpassed. I do agree that is the way to go for future additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants