From 0e18cd8d4e3af3f3be6b921f9f81e95009b6972a Mon Sep 17 00:00:00 2001 From: Tanya <62726866+TanyaStere42@users.noreply.github.com> Date: Wed, 11 Dec 2024 11:00:42 -0800 Subject: [PATCH 1/2] Update to include NFRs --- .github/pull_request_template.md | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 246a33bd01..3f19eed7b0 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,11 +1,10 @@ -[Plain-text summary description of the solution] +[Plain-text summary description of the solution. Include any model updates, new or edited functions, significant changes to UX, etc] PR fixes #[REPLACE WITH ISSUE NUMBER] -**Changes** -- [bullet list include any model updates] -- [new or edited functions] -- [significant changes to UX] -- [design decisions, especially if architectural patterns are new/altered] -- [can use text, screenshots, or files] -- [a callout of any ##TODO or ##FIXMEs found/created as part of the fix] +**Before you Submit!** +* Is all the text internationalized? +* If you made a change to the header, did you update the react, jsp, and html? +* Are all depedencies at a locked version? +* Did you adhere to [best practices](https://wildbook.docs.wildme.org/contribute/code-guide.html)? +* Is there a quick [unit test](https://wildbook.docs.wildme.org/contribute/tests.html) you can add? From 370893e34c3d79f5fbae8c2e7c4828e1029e6009 Mon Sep 17 00:00:00 2001 From: Tanya <62726866+TanyaStere42@users.noreply.github.com> Date: Thu, 12 Dec 2024 14:00:01 -0800 Subject: [PATCH 2/2] change model to class is java! use java words --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3f19eed7b0..a6de0d6854 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,4 +1,4 @@ -[Plain-text summary description of the solution. Include any model updates, new or edited functions, significant changes to UX, etc] +[Plain-text summary description of the solution. Include any class updates, new or edited functions, significant changes to UX, etc] PR fixes #[REPLACE WITH ISSUE NUMBER]