Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved bitcoind onion-grater profile #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ApacheSub
Copy link

@ApacheSub ApacheSub commented Aug 10, 2023

It is infact not necessary to use bind=0.0.0.0:8334=onion in bitcoind.conf. It is only necessary with the current version of the profile. I've added support to use bind=10.152.152.XX:8334=onion. When 0.0.0.0 is used, bitcoin-cli -netinfo incorrectly displays incoming onion connections as npr. I've tested this profile and it will classify them correctly after the change. I assume the problem is binding to 0.0.0.0.

I also fixed the fact that dots are not being escaped in the patterns.

Please be mindful of any typos.

…XX:8334=onion to be used and will allow bitcoin-cli netinfo to display onion inbound connections correctly instead of being displayed as npr.
@ApacheSub
Copy link
Author

I've found a typo. On each line with \d{1.3}, it should be \d{1,3}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant