Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore modules option #67

Open
tsloughter opened this issue Sep 4, 2023 · 3 comments
Open

ignore modules option #67

tsloughter opened this issue Sep 4, 2023 · 3 comments

Comments

@tsloughter
Copy link

Using https://github.com/tomas-abrahamsson/gpb there is generated code like:

e_type_string(S, Bin, _TrUserData) ->
    Utf8 = unicode:characters_to_binary(S),
    Bin2 = e_varint(byte_size(Utf8), Bin),
    <<Bin2/binary, Utf8/binary>>.

Since unicode:characters_to_binary/1 can return an error or incomplete tuple the byte_size function call fails to type check.

With gradualizer I ignore these modules:

{gradualizer_opts, [{exclude_modules, [opentelemetry_exporter_trace_service_pb,
                                       opentelemetry_exporter_metrics_service_pb,
                                       opentelemetry_exporter_logs_service_pb,
                                       opentelemetry_zipkin_pb]}]}.

It'd be nice if eqwalizer had a similar option.

@ilya-klyuchnikov
Copy link
Member

As pointed out in WhatsApp/eqwalizer#37 (comment) - we have recently released ELP which has more options and flexibility for running eqwalizer. And it does support ignoring modules via putting -eqwalizer(ignore). in the module's body.

@tsloughter
Copy link
Author

Thanks I noticed ELP this morning and am actually trying it out.

But adding to a module body doesn't help here since the module is generated. I'd just put the %% eqwalizer:ignore if it wasn't a generated module.

@ilya-klyuchnikov
Copy link
Member

This issue belongs now more to ELP (in terms of managing options and configurations). Transferring to ELP

@ilya-klyuchnikov ilya-klyuchnikov transferred this issue from WhatsApp/eqwalizer Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants