Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConversionError(InvalidExpression) when using an invalid parse transform #35

Open
robertoaloi opened this issue Jul 5, 2024 · 0 comments
Labels
bug Something isn't working prio-low

Comments

@robertoaloi
Copy link
Contributor

When using an old version of lager that had not been updated to support OTP 24+ line/col numbers, the lager parse transform produced an invalid AST. ELP did not complain during compilation, but eventually logged a ConversionError(InvalidExpression) error.

To repro, logging any message using a version of lager older than d255955 will trigger the ConversionError(InvalidExpr).

We could improve logging in this case, to make the error more obvious to the user. Originally reported in Slack.

@robertoaloi robertoaloi added bug Something isn't working prio-low labels Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working prio-low
Projects
None yet
Development

No branches or pull requests

1 participant