Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling when storage is invalid #98

Open
WesleyBranton opened this issue Sep 23, 2021 · 0 comments
Open

Improve error handling when storage is invalid #98

WesleyBranton opened this issue Sep 23, 2021 · 0 comments
Labels
bug Something isn't working P3 This issue is considered medium priority

Comments

@WesleyBranton
Copy link
Owner

WesleyBranton commented Sep 23, 2021 •
edited
Loading

Currently, if the user is missing the defaultProfile key in the storage, this causes a number of issues:

  • The error in the console is not descriptive enough
  • The popup dialog displays no settings
  • The settings page loads no profile automatically, which causes additional issues
    • Settings cannot be saved unless a profile is created or a valid profile is selected

If the profile object that's being used for the default profile is missing from the storage, it produces many of the same errors as listed above.
@WesleyBranton WesleyBranton added bug Something isn't working P3 This issue is considered medium priority labels Sep 23, 2021
@WesleyBranton WesleyBranton changed the title Improve error handling when defaultProfile key is missing Improve error handling when storage is invalid Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working P3 This issue is considered medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@WesleyBranton