Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing integration test in addons-test.js #3181

Open
benfrancis opened this issue Nov 22, 2024 · 0 comments
Open

Failing integration test in addons-test.js #3181

benfrancis opened this issue Nov 22, 2024 · 0 comments
Labels
Milestone

Comments

@benfrancis
Copy link
Member

Oops, I missed a failing integration test after bumping the version in package.json to 2.0.0-alpha.1 in #3179

FAIL test/integration/addons-test.js (19.163 s)
  ● addons › Fail manifest.json with wrong gateway min version

    expect(received).toBeTruthy()

    Received: undefined

      403 |       (<Record<string, unknown>>manifest.gateway_specific_settings).webthings
      404 |     )).strict_min_version = semver.inc(pkg.version, 'major')!;
    > 405 |     expect(await loadSettingsAdapterWithManifestJson(manifest)).toBeTruthy();
          |                                                                 ^
      406 |   });
      407 |
      408 |   it('Fail manifest.json with wrong gateway max version', async () => {

      at Object.toBeTruthy (../src/test/integration/addons-test.ts:405:65)
@benfrancis benfrancis added the bug label Nov 22, 2024
@benfrancis benfrancis added this to the 2.0 milestone Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant