From d520fe555e235ae64e4248721d1fb2d840ffa964 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Wed, 13 Nov 2024 14:37:03 +0100 Subject: [PATCH] Mark the PerformanceMetrics methods as overrides of IPlugin [28/34] Building CXX object PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o FAILED: PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o /Applications/Xcode_15.4.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ -DPROCESSCONTAINERS_ENABLED=1 -DTHUNDER_PLATFORM_PC_UNIX=1 -DThunderPerformanceMetrics_EXPORTS -DWARNING_REPORTING_ENABLED -D_TRACE_LEVEL=0 -D__CORE_MESSAGING__ -D__CORE_NO_WCHAR_SUPPORT__ -D__CORE_WARNING_REPORTING__ -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include -isystem /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/processcontainers -Wall -Wextra -Wpedantic -Werror -g -std=gnu++11 -arch arm64 -isysroot /Applications/Xcode_15.4.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk -fPIC -fvisibility=hidden -fvisibility-inlines-hidden -O0 -g -MD -MT PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o -MF PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o.d -o PerformanceMetrics/CMakeFiles/ThunderPerformanceMetrics.dir/PerformanceMetrics.cpp.o -c /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:667:30: error: 'Initialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual const string Initialize(PluginHost::IShell* service); ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:81:30: note: overridden virtual function is here virtual const string Initialize(PluginHost::IShell* shell) = 0; ^ In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:673:22: error: 'Deinitialize' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual void Deinitialize(PluginHost::IShell* service); ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:90:22: note: overridden virtual function is here virtual void Deinitialize(PluginHost::IShell* shell) = 0; ^ In file included from /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.cpp:20: /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/ThunderNanoServicesRDK/PerformanceMetrics/PerformanceMetrics.h:677:24: error: 'Information' overrides a member function but is not marked 'override' [-Werror,-Winconsistent-missing-override] virtual string Information() const; ^ /Users/runner/work/ThunderNanoServicesRDK/ThunderNanoServicesRDK/Debug/install/usr/include/Thunder/plugins/IPlugin.h:97:24: note: overridden virtual function is here virtual string Information() const = 0; ^ 3 errors generated. --- PerformanceMetrics/PerformanceMetrics.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/PerformanceMetrics/PerformanceMetrics.h b/PerformanceMetrics/PerformanceMetrics.h index fd2b80e..2253b37 100644 --- a/PerformanceMetrics/PerformanceMetrics.h +++ b/PerformanceMetrics/PerformanceMetrics.h @@ -664,17 +664,17 @@ POP_WARNING() // If there is an error, return a string describing the issue why the initialisation failed. // The Service object is *NOT* reference counted, lifetime ends if the plugin is deactivated. // The lifetime of the Service object is guaranteed till the deinitialize method is called. - virtual const string Initialize(PluginHost::IShell* service); + virtual const string Initialize(PluginHost::IShell* service) override; // The plugin is unloaded from Thunder. This is call allows the module to notify clients // or to persist information if needed. After this call the plugin will unlink from the service path // and be deactivated. The Service object is the same as passed in during the Initialize. // After theis call, the lifetime of the Service object ends. - virtual void Deinitialize(PluginHost::IShell* service); + virtual void Deinitialize(PluginHost::IShell* service) override; // Returns an interface to a JSON struct that can be used to return specific metadata information with respect // to this plugin. This Metadata can be used by the MetData plugin to publish this information to the ouside world. - virtual string Information() const; + virtual string Information() const override; private: