Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser polish and trimming #11

Open
noahgibbs opened this issue Apr 28, 2021 · 0 comments
Open

Parser polish and trimming #11

noahgibbs opened this issue Apr 28, 2021 · 0 comments

Comments

@noahgibbs
Copy link
Collaborator

noahgibbs commented Apr 28, 2021

The parser is some of the oldest code in SkotOS. It hardcodes a number of verbs of various types in several different lower-level-than-Merry locations, generally because that code predates Merry.

  • The places where that's correct behaviour (e.g. chatmode hardcodes the "say" verb) should be documented.
  • The places where the verbs are outdated (e.g. the ancient study-and-learning skills verbs) should be removed.
  • Where the verbs are useful and easily moved, they should be moved to Merry
  • Where the verbs are useful and not easily moved, an issue should be filed
  • In all of these cases, tests should be written -- not for every verb, but at least for every type of verb

I should catalog what verbs are currently available in core SkotOS, with particular focus on verbs available to non-staff-members.

Verbs that are irrelevant to RWOT should be removed, made optional or otherwise kept from being an attractive nuisance.

Est: 3-4 days. This is hard to be sure of - how much do we want to do? 4 days wouldn't give us every verb sorted and tested, but could probably get us vRWOT-ready with a list of other work and every verb type tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant