Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Implement xdg-activation v1 protocol plugin #1898

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

kode54
Copy link
Contributor

@kode54 kode54 commented Sep 15, 2023

This is a draft, in case it is desired to implement the XWayland equivalent of this protocol into the same plugin.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After looking at the sway pr, I see that the launcher contexts are optional (we don't have that concept in wayfire yet so it can be left aside).

Also, leaving a few comments, even though this is a draft :)

plugins/protocols/xdg-activation.cpp Outdated Show resolved Hide resolved
plugins/protocols/xdg-activation.cpp Outdated Show resolved Hide resolved
plugins/protocols/xdg-activation.cpp Outdated Show resolved Hide resolved
@ammen99
Copy link
Member

ammen99 commented Sep 16, 2023

I think something went wrong, because I do not see any changes since last time ..

@kode54
Copy link
Contributor Author

kode54 commented Sep 17, 2023

Oh, that's ducking stupid. I somehow managed to amend commit without staging the new files.

Copy link
Member

@ammen99 ammen99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ammen99 ammen99 merged commit 16e0223 into WayfireWM:master Sep 22, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants