Random crash in squeezimize

[dkondor]

Describe the bug
This has happened twice in the past days, but does not seem to be predictable yet. I'll try to run with debug info enabled.

To Reproduce

1. Enable squeezimize animation
2. Try to minimize a view
3. Crash (see the stacktrace below)

Expected behavior
No crash.

Screenshots or stacktrace

Dec 07 10:44:52 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:52.805 - [src/main.cpp:142] Fatal error: Segmentat
ion fault
Dec 07 10:44:52 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:52.831 - #1  signal_handler(int) main.cpp:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.417 - #2  __restore_rt libc_sigaction.c:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.438 - #3  wf::output_t::get_relative_geometry()
 const ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.458 - #4  wf::squeezimize::squeezimize_transfor
mer::simple_node_render_instance_t::render(wf::render_target_t const&, wf::region_t const&) ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.478 - #5  wf::scene::run_render_pass(wf::scene:
:render_pass_params_t const&, unsigned int) ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.500 - #6  wf::render_manager::impl::render_outp
ut() ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.517 - #7  wf::render_manager::impl::paint() ??:
?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.539 - #8  handle_timeout(void*) util.cpp:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.552 - #9  wl_event_loop_dispatch ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.566 - #10 wl_display_run ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.586 - #11 main ??:?
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.718 - #12 __libc_start_call_main ../sysdeps/x86
/libc-start.c:74
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.848 - #13 call_init ../csu/libc-start.c:128
Dec 07 10:44:53 thinkpad-x230 wayfire[2467]: EE 07-12-24 10:44:53.871 - #14 _start ??:?

Wayfire version
latest git 0.10.0-7b44ec62 (Dec 6 2024) branch master wlroots-0.17.2

[ammen99]

Not sure about the proper fix yet, but here is a test which reproduces this crash: ammen99/wayfire-tests@30e73a3

[ammen99]

I think that #2534 should fix this and any related crashes, please test and let me know whether you experience any other crashes.

[dkondor]

OK, will test!