Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked bar charts are invalid when showing percent change from another model run #87

Open
nickrsan opened this issue Dec 5, 2023 · 0 comments
Assignees
Labels
bug Something isn't working front end Requires front end work priority

Comments

@nickrsan
Copy link
Member

nickrsan commented Dec 5, 2023

The application calculates the percent change between a comparison model run and the other model runs by differencing the raw values then dividing. Then, if a user enables the chart stacking, it sums up the percents. For all non-percent values, summing the model run differences is fine, but for percents it produces a meaningless result.

We need to either swap the order so that we sum the differences and then divide by the total rather than getting the percents and summing them, or we need to disable stacking when we are in percent change mode (which has edge cases to detect similar to enabling the baseline run).

@nickrsan nickrsan added bug Something isn't working front end Requires front end work priority labels Dec 5, 2023
@nickrsan nickrsan self-assigned this Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end work priority
Projects
Development

No branches or pull requests

1 participant