Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] remove publish limit #111

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[CI] remove publish limit #111

merged 1 commit into from
Jun 19, 2024

Conversation

L-jasmine
Copy link
Collaborator

No description provided.

Copy link
Member

juntao commented Jun 19, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 722a401fcb16721c0a10cd00821fa977e72ff8e1

Key Changes:

  1. The patch removes the conditional statements "if: github.ref == 'refs/heads/main'" from the "Publish" and "Deploy API document" steps in the GitHub Actions workflow file ".github/workflows/release-wasmedge-sys.yml".
  2. The removal of these conditions allows the "Publish" and "Deploy API document" steps to run without being constrained to a specific branch (main).

Potential Problems:

  1. Loss of control: By removing the condition that restricted the "Publish" and "Deploy API document" steps to run only on the 'main' branch, these steps could now be triggered on any branch. This might lead to unintended or premature publishing or deployment of changes before they are ready.
  2. Security implications: If the publishing and deployment steps are not meant to run on every branch, removing this limitation could potentially expose sensitive information or unstable changes to end-users or external services prematurely.

Recommendation:

  1. Consider the original intent of limiting the publish and deploy actions to the 'main' branch. If this restriction was put in place for a specific reason (e.g., to ensure stability or compliance with release processes), evaluate the impact of removing it.
  2. If removing the limitation is necessary, consider implementing alternative safeguards or checks to ensure that the publishing and deployment processes are still controlled and secure, such as introducing manual approvals or additional verification steps.
  3. Test the changes thoroughly on different branches to ensure that the workflow behaves as expected without the branch restriction.

@L-jasmine L-jasmine merged commit cbd9e3a into WasmEdge:0.13.x Jun 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants