Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cross-plaform type #109

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Conversation

L-jasmine
Copy link
Collaborator

No description provided.

Copy link
Member

juntao commented Jun 17, 2024

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 49c1f5c1c5bd0b39b541be56199dce48ec91070e

Key Changes:

  • The patch modifies the c_strs variable declaration in the impl PluginManager block inside the plugin.rs file.
  • It changes the type of the c_strs variable from Vec<*const i8> to Vec<*const ::std::os::raw::c_char> for better cross-platform compatibility.

Potential Problems:

  1. The change from Vec<*const i8> to Vec<*const ::std::os::raw::c_char> may cause compatibility issues with existing code that relies on the previous type.
  2. Verify if the conversion to ::std::os::raw::c_char is appropriate for the intended usage and if it aligns with the conventions and requirements of the project.
  3. It would be beneficial to ensure that the necessary dependencies and imports for ::std::os::raw::c_char are correctly included and handled in all target platforms.

@L-jasmine L-jasmine merged commit 706d047 into WasmEdge:main Jun 18, 2024
37 checks passed
@hydai hydai deleted the fix/cross-platform branch June 18, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants