This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Code organization #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prnewman
suggested changes
May 24, 2017
| @@ -209,9 +209,56 @@ class MyViewController: UIViewController, UITableViewDataSource, UIScrollViewDel | |||
| } | |||
| ``` | |||
|
|
|||
| Since the compiler does not allow you to re-declare protocol conformance in a derived class, it is not always required to replicate the extension groups of the base class. This is especially true if the derived class is a terminal class and a small number of methods are being overridden. When to preserve the extension groups is left to the discretion of the author. | |||
| For UIKit views and controllers, besides separating protocol methods into their own extesion, also separate your class into section using `// MARK: -` to group lifecycle methods, setup methods, and action methods. | |||
There was a problem hiding this comment.
Comments
Where possible, separate your classes into sections using // MARK: - comments to group lifecycle methods, setup methods, and action methods. Like TODO: and FIXME:, MARK: comments appear in the Xcode source navigator.
| // setup Refresh Controller | ||
| } | ||
|
|
||
| // MARK: - Action |
|
|
||
| } | ||
|
|
||
| // MARK: - UITableView DataSource and Delegate |
There was a problem hiding this comment.
UITableViewDataSource and UITableViewDelegate methods
| // table view data source methods | ||
| } | ||
|
|
||
| // MARK: - UIScrollViewDelegate |
| // init code here.. | ||
| } | ||
|
|
||
| // MARK: - Life Cycle |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.) Generalized the Protocol Conformance rule for all classes instead of just models.
2.) Removed confusing paragraph about replicating extensions.
3.) Added a rule to help standardize the layout of UIViews and UIViewControllers.