From 98a2c4062024da910f63a902763e4cdae3b722b7 Mon Sep 17 00:00:00 2001
From: David Schultz <david.schultz@icecube.wisc.edu>
Date: Wed, 4 Dec 2024 14:46:39 -0600
Subject: [PATCH] make sure the job actually completed, and didn't get held or
 removed

---
 iceprod/server/plugins/condor.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/iceprod/server/plugins/condor.py b/iceprod/server/plugins/condor.py
index b0f547b1..f9039aef 100644
--- a/iceprod/server/plugins/condor.py
+++ b/iceprod/server/plugins/condor.py
@@ -902,7 +902,7 @@ async def check_history(self):
             if time_ is not None:
                 resources['time'] = time_/3600.
 
-            success = extra.get('ExitCode', 1) == 0
+            success = extra.get('JobStatus') == 4 and extra.get('ExitCode', 1) == 0
             job.status = JobStatus.COMPLETED if success else JobStatus.FAILED
 
             stats = {}