From ed150a4a76273c30b5ac2f57883b476c5b469785 Mon Sep 17 00:00:00 2001
From: Dominic Farolino <domfarolino@gmail.com>
Date: Fri, 5 Jan 2024 12:15:21 -0500
Subject: [PATCH 1/3] Spec the `toArray()` operator

---
 spec.bs | 31 ++++++++++++++++++++++++-------
 1 file changed, 24 insertions(+), 7 deletions(-)

diff --git a/spec.bs b/spec.bs
index c0d23c7..08265a2 100644
--- a/spec.bs
+++ b/spec.bs
@@ -34,6 +34,8 @@ urlPrefix: https://dom.spec.whatwg.org; spec: DOM
       text: passive; url: event-listener-passive
       text: once; url: event-listener-once
       text: signal; url: event-listener-signal
+    for: AbortSignal
+      text: dependent signals; url: abortsignal-dependent-signals
 </pre>
 
 <style>
@@ -521,7 +523,7 @@ An <dfn>internal observer</dfn> is a [=struct=] with the following [=struct/item
        Note: This can happen when {{SubscribeOptions}}'s {{SubscribeOptions/signal}} is already
        [=AbortSignal/aborted=].
 
-    1. Otherwise, [=AbortSignal/add=] the following algorithm to |subscriber|'s
+    1. Otherwise, [=AbortSignal/add|add the following abort algorithm=] to |subscriber|'s
        [=Subscriber/signal=]:
 
        1. [=close a subscription|Close=] |subscriber|.
@@ -605,21 +607,36 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w
 
     1. Let |p| [=a new promise=].
 
+    1. If |options|'s {{SubscribeOptions/signal}} is [=AbortSignal/aborted=], then:
+
+       1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
+          reason=].
+
+       1. Return |p|.
+
+    1. [=AbortSignal/add|Add the following abort algorithm=] to |options|'s
+       {{SubscribeOptions/signal}}:
+
+       1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
+          reason=].
+
+       Note: All we have to do here is [=reject=] |p|. Note that the subscription to [=this=]
+       {{Observable}} will also be canceled automatically, since the "inner" [=Subscriber/signal=]
+       (created during <a for=Observable lt="subscribe to an Observable">subscription</a>) is a
+       [=AbortSignal/dependent signal=] of |options|'s {{SubscribeOptions/signal}}.
+
     1. Let |values| be a new [=list=].
 
     1. Let |observer| be a new [=internal observer=], initialized as follows:
 
        : [=internal observer/next steps=]
-       :: <span class=XXX>TODO: Add the value to |values|.</span>
+       :: [=list/Append=] the passed in <var ignore>value</var> to |values|.
 
        : [=internal observer/error steps=]
-       :: <span class=XXX>TODO: [=Reject=] |p| with an error.</span>
+       :: [=Reject=] |p| with the passed in <var ignore>error</var>.
 
        : [=internal observer/complete steps=]
-       :: <span class=XXX>TODO: [=Resolve=] |p| with |values|.</span>
-
-    1. <span class=XXX>TODO: Finish the actual spec for this method and use |options|'s
-       {{SubscribeOptions/signal}} to [=reject=] |p| appropriately.</span>
+       :: [=Resolve=] |p| with |values|.
 
     1. <a for=Observable lt="subscribe to an Observable">Subscribe</a> to [=this=] given |observer|
        and |options|.

From 9f1afe61304909e7660f9d4b77c338dd9b9d988e Mon Sep 17 00:00:00 2001
From: Dominic Farolino <domfarolino@gmail.com>
Date: Tue, 9 Jan 2024 10:54:32 -0500
Subject: [PATCH 2/3] Handle inactive Document and null signal

---
 spec.bs | 30 ++++++++++++++++++------------
 1 file changed, 18 insertions(+), 12 deletions(-)

diff --git a/spec.bs b/spec.bs
index 08265a2..f81457c 100644
--- a/spec.bs
+++ b/spec.bs
@@ -605,25 +605,31 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w
 <div algorithm>
   The <dfn for=Observable method><code>toArray(|options|)</code></dfn> method steps are:
 
+    1. If [=this=]'s [=relevant global object=] is a {{Window}} object, and its [=associated
+       Document=] is not [=Document/fully active=], then return.
+
     1. Let |p| [=a new promise=].
 
-    1. If |options|'s {{SubscribeOptions/signal}} is [=AbortSignal/aborted=], then:
+    1. If |options|'s {{SubscribeOptions/signal}} is not null:
+
+       1. If |options|'s {{SubscribeOptions/signal}} is [=AbortSignal/aborted=], then:
 
-       1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
-          reason=].
+          1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
+             reason=].
 
-       1. Return |p|.
+          1. Return |p|.
 
-    1. [=AbortSignal/add|Add the following abort algorithm=] to |options|'s
-       {{SubscribeOptions/signal}}:
+       1. [=AbortSignal/add|Add the following abort algorithm=] to |options|'s
+          {{SubscribeOptions/signal}}:
 
-       1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
-          reason=].
+          1. [=Reject=] |p| with |options|'s {{SubscribeOptions/signal}}'s [=AbortSignal/abort
+             reason=].
 
-       Note: All we have to do here is [=reject=] |p|. Note that the subscription to [=this=]
-       {{Observable}} will also be canceled automatically, since the "inner" [=Subscriber/signal=]
-       (created during <a for=Observable lt="subscribe to an Observable">subscription</a>) is a
-       [=AbortSignal/dependent signal=] of |options|'s {{SubscribeOptions/signal}}.
+          Note: All we have to do here is [=reject=] |p|. Note that the subscription to [=this=]
+          {{Observable}} will also be canceled automatically, since the "inner"
+          [=Subscriber/signal=] (created during <a for=Observable lt="subscribe to an
+          Observable">subscription</a>) is a [=AbortSignal/dependent signal=] of |options|'s
+          {{SubscribeOptions/signal}}.
 
     1. Let |values| be a new [=list=].
 

From 48c33e58839c4c244303e6d26648d28e9444c7bf Mon Sep 17 00:00:00 2001
From: Dominic Farolino <domfarolino@gmail.com>
Date: Thu, 11 Jan 2024 10:12:53 -0500
Subject: [PATCH 3/3] Remove inactive Document condition

---
 spec.bs | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/spec.bs b/spec.bs
index f81457c..524dd2a 100644
--- a/spec.bs
+++ b/spec.bs
@@ -605,9 +605,6 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w
 <div algorithm>
   The <dfn for=Observable method><code>toArray(|options|)</code></dfn> method steps are:
 
-    1. If [=this=]'s [=relevant global object=] is a {{Window}} object, and its [=associated
-       Document=] is not [=Document/fully active=], then return.
-
     1. Let |p| [=a new promise=].
 
     1. If |options|'s {{SubscribeOptions/signal}} is not null: