From ecbbaa5e6b727a51d0958bc5c7b21505fb3e7be3 Mon Sep 17 00:00:00 2001 From: Marais Rossouw Date: Wed, 16 Oct 2024 12:19:47 +1000 Subject: [PATCH 1/2] docs: update spec to mention rejecting with a new RangeError --- spec.bs | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/spec.bs b/spec.bs index ed93db4..0dc4d3c 100644 --- a/spec.bs +++ b/spec.bs @@ -1523,13 +1523,10 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w :: [=Reject=] |p| with the passed in error. : [=internal observer/complete steps=] - :: [=Resolve=] |p| with {{undefined}}. + :: [=Reject=] |p| with a new {{RangeError}}, and message of "No values in Observable". Note: This is only reached when the source {{Observable}} completes *before* it emits a - single value; in this case, resolving with {{undefined}} is harmless but makes it - difficult to distinguish between the first value trule being {{undefined}} and premature - completion. See #132 for - discussion on this. + single value. 1. Subscribe to [=this=] given |internal observer| and |internal options|. From f77730eb74615644e56dd8cfb8b57e11f9771077 Mon Sep 17 00:00:00 2001 From: Marais Rossouw Date: Sun, 20 Oct 2024 21:28:45 +1000 Subject: [PATCH 2/2] chore: remove message spec as per feedback --- spec.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec.bs b/spec.bs index 0dc4d3c..ff0a981 100644 --- a/spec.bs +++ b/spec.bs @@ -1523,7 +1523,7 @@ For now, see [https://github.com/wicg/observable#operators](https://github.com/w :: [=Reject=] |p| with the passed in error. : [=internal observer/complete steps=] - :: [=Reject=] |p| with a new {{RangeError}}, and message of "No values in Observable". + :: [=Reject=] |p| with a new {{RangeError}}. Note: This is only reached when the source {{Observable}} completes *before* it emits a single value.