From df8bb3ab71435c3c2cc93349cbdc81a23a9c24be Mon Sep 17 00:00:00 2001 From: Keith Cirkel Date: Tue, 16 Jul 2024 09:50:34 +0100 Subject: [PATCH 1/2] rename SubscriptionObserverCallback to ObservableSubscriptionCallback Co-authored-by: Marais Rossouw --- spec.bs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/spec.bs b/spec.bs index dd610b8..a37416a 100644 --- a/spec.bs +++ b/spec.bs @@ -317,15 +317,15 @@ observable.subscribe({}, {signal: outerController.signal}); // SubscribeCallback is where the Observable "creator's" code lives. It's // called when subscribe() is called, to set up a new subscription. callback SubscribeCallback = undefined (Subscriber subscriber); -callback SubscriptionObserverCallback = undefined (any value); +callback ObservableSubscriptionCallback = undefined (any value); dictionary SubscriptionObserver { - SubscriptionObserverCallback next; - SubscriptionObserverCallback error; + ObservableSubscriptionCallback next; + ObservableSubscriptionCallback error; VoidFunction complete; }; -typedef (SubscriptionObserverCallback or SubscriptionObserver) ObserverUnion; +typedef (ObservableSubscriptionCallback or SubscriptionObserver) ObserverUnion; dictionary SubscribeOptions { AbortSignal signal; @@ -464,7 +464,7 @@ An internal observer is a [=struct=] with the following [=struct/item
  1. -
    If |observer| is a {{SubscriptionObserverCallback}}
    +
    If |observer| is a {{ObservableSubscriptionCallback}}
    Set |internal observer|'s [=internal observer/next steps=] to these steps that take an {{any}} |value|: From 54aa7ac5e9afe18d3cdc69e118946ecb874dfda1 Mon Sep 17 00:00:00 2001 From: Keith Cirkel Date: Mon, 22 Jul 2024 08:56:56 +0100 Subject: [PATCH 2/2] fix typo Co-authored-by: Dominic Farolino --- spec.bs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec.bs b/spec.bs index a37416a..b2bcd5e 100644 --- a/spec.bs +++ b/spec.bs @@ -464,7 +464,7 @@ An internal observer is a [=struct=] with the following [=struct/item
    1. -
      If |observer| is a {{ObservableSubscriptionCallback}}
      +
      If |observer| is an {{ObservableSubscriptionCallback}}
      Set |internal observer|'s [=internal observer/next steps=] to these steps that take an {{any}} |value|: