Skip to content
This repository has been archived by the owner on Jun 2, 2023. It is now read-only.

If I choose Bluemix deployment, I still want to know how to run locally #124

Open
rvennam opened this issue Dec 21, 2016 · 7 comments
Open

Comments

@rvennam
Copy link

rvennam commented Dec 21, 2016

Currently, if you choose the Bluemix deployment checkbox, it hides the command to run locally (http://localhost:9080/myLibertyApp)

Instead, we should show both.

@katheris
Copy link
Contributor

Fair point, I wouldn't expect people to just push Bluemix and never want to do anything locally.

@iainduncani
Copy link
Contributor

As we also have issue #113 that doesn't actually set Bluemix as a default profile when you run it I wonder if we should just ditch the check box and put both sets of instructions up there all the time and never try to make Bluemix a default profile (similar to the Gradle experience where you always have to explicitly run the cfPush).

@katheris
Copy link
Contributor

katheris commented Dec 23, 2016

I've been wondering about not ditching the checkbox, but have it so that if you select Bleumix you get the properties and profile, and if not you don't. So that people can get a simpler pom file if they don't want to deploy to Bluemix. Although if we do that we should probably provide a mechanism to add the Bluemix build code later. Then we could enable the profile in maven based on the property running.bluemix, as it's maybe confusing that setting that to true doesn't enable Bluemix.

@iainduncani
Copy link
Contributor

That's a good call, over a quarter of the POM is dedicated to the Bluemix push at the moment so it would be a good chunk to cut out + simplify

@rvennam
Copy link
Author

rvennam commented Jan 3, 2017

Personally, to deploy to Bluemix I would rather just have a simple manifest file and use cf push. I would not want to put my Bluemix credentials, org and space as maven params as part of every push.

I say we ditch all the Bluemix additions from pom.xml and simply show cf instructions:
Either:
cf push <appname> -p target/JavaHelloWorldApp.war
or give them a simple manifest.yml which has the path filled out and the user just do a cf push

Example: https://github.com/IBM-Bluemix/java-helloworld

@NottyCode
Copy link
Member

If I were doing it manually I would agree, but if I am trying to automate as a part of my devops pipeline wouldn't I want it to be integrated into my maven build?

@rvennam
Copy link
Author

rvennam commented Jan 3, 2017

If we want to cover that case, I would want a checkbox for "Bluemix - CloudFoundry Maven Integration", which to me is clearer than "Bluemix default deployment"

We can also add "Bluemix - Docker Container Maven Integration"

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants