Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is ambiguos #98

Open
tad1693 opened this issue Jul 23, 2019 · 0 comments
Open

README.md is ambiguos #98

tad1693 opened this issue Jul 23, 2019 · 0 comments

Comments

@tad1693
Copy link

tad1693 commented Jul 23, 2019

On the project local README it says Create a src/config/local.json file and customize it for your local setup, you can use src/config/local.example.json suggesting to use local.example.json from the src/config directory if the user doesn't want to create the local.json, but on the config/index.js file never verifies if local.json exists.

Here is the snapshot of the config/index.js file

const path = require("path");
const env = process.env.NODE_ENV || "local";

const configFile = require(path.join(__dirname, `${env}.json`));

A better solution will be to use by default the local.example.json

This is the output of the console after running the project without having created the local.json file

image

rmberrios added a commit to rmberrios/voxa-cli that referenced this issue Dec 18, 2019
rmberrios added a commit that referenced this issue Dec 18, 2019
* remove office 365 test, leave excel file

* update xcel templates

* fixess #98 - use local.example by default

* update links, update github theme
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant