Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/promises #32

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

aamadeo27
Copy link

Most of the async operations are modified to return promises.
VoltTable support as a parameter ( volttable class in lib/volttable.js ).
Reconnect Capabilities.
More tests.
Hashinator implementation.
Sugar methods for: adHoc, updateClasses, systemOverview and others.

@benjaminballard
Copy link
Contributor

Albert, there are many files / lines modified in this pull request where the change is replacing single quotes with double quotes. While we never declared a standard, our existing code in the driver uses single quotes, so we'd like to keep this the same for consistency. Can you revert all of those changes, that will make it easier for us to review the consequential changes in this request. Thanks!

@aamadeo27
Copy link
Author

Sure, if you find any other convention difference I'll change it to the convention you guys use.
I'll make the changes tonight.

@aamadeo27
Copy link
Author

Now that you mention, I think the /tests had the double quotes and defined a .eslintrc with a double quote rule.

If it's ok with you, I'll change the /tests to use sinlge quotes too.

@benjaminballard
Copy link
Contributor

Yes, that would be great. It will help make the project more consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants