Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken by Paper's new plugin loader #8

Open
datatags opened this issue Feb 22, 2023 · 3 comments · May be fixed by #9
Open

Broken by Paper's new plugin loader #8

datatags opened this issue Feb 22, 2023 · 3 comments · May be fixed by #9

Comments

@datatags
Copy link

Paper just rewrote their plugin loader, involving some change that breaks plugins that unregister other plugins. Is there anything that can be done to work around this?

Specifically, what's happening is that the old version of the plugin will be disabled, but the new version is not loaded. Here's what the log looks like:

[11:59:23 INFO]: [BileTools] File change detected: UltraCosmetics-3.0-DEV-b7.jar
[11:59:23 INFO]: [BileTools] Identified Plugin: UltraCosmetics <-> UltraCosmetics-3.0-DEV-b7.jar
[11:59:23 INFO]: [BileTools] Reloading: UltraCosmetics
[11:59:23 INFO]: [BileTools] [STDOUT] Backed up UltraCosmetics 3.0-DEV-b7
[11:59:23 INFO]: [Bile]: Unloading UltraCosmetics
[11:59:23 INFO]: [UltraCosmetics] Disabling UltraCosmetics v3.0-DEV-b7

It seems like this is the check that's failing with the change in Paper:

if (getPlugin(file) != null) {
    return;
}
@polypixeldev
Copy link

I am also having this issue

@Stephcraft
Copy link

Me too

@xNasuni
Copy link

xNasuni commented May 19, 2023

same

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants