Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write non-SurfaceReactions to CTI files #192

Open
francescalb opened this issue Nov 5, 2021 · 0 comments
Open

Write non-SurfaceReactions to CTI files #192

francescalb opened this issue Nov 5, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@francescalb
Copy link

Is your feature request related to a problem? Please describe.
I wish to be able to write gasphase reactions in cti-format for cantera/openmkm. As of now it seems to me
that the only reaction type that has this function is the pmutt.omkm.SurfaceReaction.

Describe the solution you'd like
I would like to have a to_cti and to_omkm_yaml functions defined for reaction types that is not SurfaceReaction, most specifically
gas phase reactions for now.

Describe alternatives you've considered
I am not sure which solution is the best, but I can think of two possibilities. 1) to declare an new pmutt.omkm.GasReaction class
that inherits from pmutt.reaction.Reaction and has to_cti and to_omkm_yaml defined.
or alternatively, define them directly in the pmitt.reaction.Reaction class.

Additional context
I am happy to contribute here, but am not sure how you would prefer this done. Also, I might need help for the specification of the output.

@francescalb francescalb added the enhancement New feature or request label Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant