Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error editing or deleting product groups #327

Open
tom-rice opened this issue Jun 17, 2016 · 1 comment
Open

Error editing or deleting product groups #327

tom-rice opened this issue Jun 17, 2016 · 1 comment

Comments

@tom-rice
Copy link

tom-rice commented Jun 17, 2016

On the /dashboard/store/products/groups page, if I tried to click the edit or trash button on any of the groups I got a javascript error such as:
Error: Syntax error, unrecognized expression: li['data-group-id=1']

Fixed by editing lines 79, 80, 83 and 84 of js/vividStoreFunctions.js in the edit and cancel functions:
Changed these:

FROM:
$("li['data-group-id="+groupID+"']")

TO:
$("li[data-group-id='"+groupID+"']")

ALSO I then hit an additional error with line 48 of that file:
var confirmDelete = confirm(vividStore.Strings.AreYouSure);
ReferenceError: vividStore is not defined
I have hardcoded that confirmation message on mine for now - perhaps you can fix.

@brucewyne
Copy link

The second error is odd that it had that issue. The first is an easy fix. Though if you submit a pull request that would be easier ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants