Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot increase qty if stock count unlimited #324

Open
tom-rice opened this issue Jun 10, 2016 · 1 comment
Open

Cannot increase qty if stock count unlimited #324

tom-rice opened this issue Jun 10, 2016 · 1 comment

Comments

@tom-rice
Copy link

tom-rice commented Jun 10, 2016

When viewing a product page, if the product is set to "Unlimited" stock, I am seeing a value of 0 the max="" box on the quantity input box. This prevents clicking the "Up" arrow to increase the stock count.

The quantity input on the product modal popup or on the cart page do not have this issue. It's only a problem in blocks/vivid_product/view.php

I think it just needs this added to the if condition on line 143 of blocks/vivid_product/view.php, as I see you've done on elements/cart_modal.php:
|| $product->isUnlimited()

@tom-rice
Copy link
Author

tom-rice commented Jun 10, 2016

On a related note - I just thought I would test this with different stock quantities for each variation, and the max="" is currently just limiting it by the quantity in the first variation. Perhaps needs a javascript solution to limit the max by the quantity of whichever option variation is selected.
Or, just don't limit it if using advanced variations for now until this can be implemented?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant