Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can grid markup default to the theme settings? #315

Open
brucewyne opened this issue May 18, 2016 · 0 comments
Open

Can grid markup default to the theme settings? #315

brucewyne opened this issue May 18, 2016 · 0 comments

Comments

@brucewyne
Copy link

brucewyne commented May 18, 2016

The idea behind using our own "grid framework" was to be agnostic about the theme we use. That said, it'd be nicer to conform to what the theme is using.

The idea would be that we could do something like:

<?=$grid->openContainer()?>`
    <?=$grid->openColumn(4)?> 
        <div class="product-image">
            ....
        </div>
    <?=$grid->closeColumn()?>
    <?=$grid->openColumn(8)?> 
        <div class="product-description">
            ....
        </div>
    <?=$grid->closeColumn()?>
<?=$grid->closeContainer?>

Is this overkill? Or should we just stick with a simple agnostic grid we use now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant