Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting VRT fails if the provided API_URL ends with / #25

Open
AdamHepner opened this issue Aug 16, 2021 · 1 comment · May be fixed by #26
Open

Starting VRT fails if the provided API_URL ends with / #25

AdamHepner opened this issue Aug 16, 2021 · 1 comment · May be fixed by #26
Labels
enhancement New feature or request

Comments

@AdamHepner
Copy link

This was lengthy investigation, but basically, in the "start" function (line 39 of visualRegressionTracker.py) you use string concatenation to build target URL. If hostname ends with "/", the result is:
https://my.url.com//builds
to which the server responds with 404 and invalid "Project not found".

Instead a urllib.parse.urljoin should've been used to avoid this type of problem (see https://stackoverflow.com/questions/1793261/how-to-join-components-of-a-path-when-you-are-constructing-a-url-in-python)

@AdamHepner AdamHepner linked a pull request Aug 16, 2021 that will close this issue
@pashidlos pashidlos added the enhancement New feature or request label Aug 18, 2021
@pashidlos
Copy link
Member

@AdamHepner thanks for your request
sure, this could be done as improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants