Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use urllib.parse.urljoin instead of string concat #26

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use urllib.parse.urljoin instead of string concat #26

wants to merge 1 commit into from

Conversation

AdamHepner
Copy link

Fixes #25

This is a quick fix, but I don't know if it breaks anything else, and to be honest I don't have time to check it right now. Hope it helps anyway.

pashidlos
pashidlos requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@pashidlos pashidlos left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contribution @AdamHepner!

there are more places to cover
could you complete them all?

@AdamHepner
Copy link
Author

I can look into it when I have time, but can't tell when this will be

@sonarcloud
Copy link

sonarcloud bot commented Aug 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pashidlos pashidlos pashidlos requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Starting VRT fails if the provided API_URL ends with /
2 participants
@AdamHepner @pashidlos