From 995b67811e3b21ccc5ba8b739029b5a0358c46e8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Jamro=C5=BCek?= Date: Mon, 13 May 2024 09:06:38 +0200 Subject: [PATCH 1/2] chore: NO-JIRA add pull request template --- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++++++ 1 file changed, 8 insertions(+) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..4b6a6893 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,8 @@ +## What did you implement? + +_A summary of the change from the implementation perspective that could help +reviewers understanding the whole solution_ + +## Checklist: + +- [ ] I exported my component in [src/index.ts](https://github.com/VirtusLab/tetrisly-react/blob/main/src/index.ts) file. From 6857dda498429f211c69c5235f348c839b678f52 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=C5=82=20Jamro=C5=BCek?= <167776055+mjamrozekvl@users.noreply.github.com> Date: Tue, 14 May 2024 08:29:26 +0200 Subject: [PATCH 2/2] chore: NO-JIRA add suggested checkboxes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Mateusz Wlekliński <114148518+mwleklinski@users.noreply.github.com> --- .github/PULL_REQUEST_TEMPLATE.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4b6a6893..8d962215 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -6,3 +6,6 @@ reviewers understanding the whole solution_ ## Checklist: - [ ] I exported my component in [src/index.ts](https://github.com/VirtusLab/tetrisly-react/blob/main/src/index.ts) file. +- [ ] I described colors, spacing, typography, and similar attributes with Figma Tokens and they are placed in the config object in the `*.styles` file +- [ ] I tested the component (including custom prop) +- [ ] I've written a storybook story for the component