You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some confusing / unclear parameter names in the source code. For example:
final case class DependencyProvider(
intelliJ: IntelliJDependencyProvider,
plugin: PluginDependencyProvider,
jbr: JbrDependencyProvider
)
Where we have plugin: PluginDependencyProvider and later on we have following method call in the code: val file = dependencies.plugin.fetch(plugin)
Where first plugin refers to the PluginDependencyProvider type and second one to an object of Plugin type. There are more cases like this one. We should rename such fields / parameters for better code readability.
The text was updated successfully, but these errors were encountered:
There are some confusing / unclear parameter names in the source code. For example:
Where we have
plugin: PluginDependencyProvider
and later on we have following method call in the code:val file = dependencies.plugin.fetch(plugin)
Where first
plugin
refers to thePluginDependencyProvider
type and second one to an object ofPlugin
type. There are more cases like this one. We should rename such fields / parameters for better code readability.The text was updated successfully, but these errors were encountered: