Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output from machete-pre-rebase and machete-post-slide-out should end up in Git Console, as with standard git hooks #1648

Open
PawelLipski opened this issue Apr 16, 2023 · 1 comment

Comments

@PawelLipski
Copy link
Collaborator

As for now, there's no way to check that output... it's only included in error message in case of a failure.

Note that implementing this task would mean that there's no longer a shared implementation for hooks b/w backend:impl (machete-status-branch) and frontend:actions (machete-pre-rebase and machete-post-slide-out), and hence the implementation for hooks can be moved out of backend:api.

Inb4, we don't want the output of machete-status-branch hook to end up in Git Console, as it's invoked far too many times.

@PawelLipski PawelLipski changed the title The output from machete-pre-rebase and machete-post-slide-out could end up in Git Console, as with standard git hooks Output from machete-pre-rebase and machete-post-slide-out could end up in Git Console, as with standard git hooks Apr 17, 2023
@PawelLipski
Copy link
Collaborator Author

PawelLipski commented Apr 17, 2023

Huh it might be undoable... mostly coz the output in Git Console seems to come from operations executed via git4idea.commands.GitTextHandler, which are assumed to use git as an executable. This handles git built-in hooks (like pre-commit etc.) well, since they're executed indirectly by git itself... but in case of machete-specific hooks, we run them directly from IntelliJ, bypassing git executable ☹️

@PawelLipski PawelLipski changed the title Output from machete-pre-rebase and machete-post-slide-out could end up in Git Console, as with standard git hooks Output from machete-pre-rebase and machete-post-slide-out should end up in Git Console, as with standard git hooks Aug 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant