Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function for making typing of neurons obsolete #272

Open
dosumis opened this issue Nov 22, 2022 · 1 comment
Open

Add function for making typing of neurons obsolete #272

dosumis opened this issue Nov 22, 2022 · 1 comment
Assignees

Comments

@dosumis
Copy link
Member

dosumis commented Nov 22, 2022

We are beginning to get corrections to typing of images from major datasets. Rather than silently changing these, we have agreed that the old typing should be retained along with metadata. This needs to be outside of the indexing/query system - which can be most easily achieved by using and annotation property.

Function should take a list of tuples as an arg. Tuples have: individual ID, type ID (FBbt), comment. It should then convert the type edges specified to an annotation property 'oio:obsolete_type', annotated with the comment (rdfs:comment).

Adding new, corrected typing should be a second step using existing pipelines.

Limitation: If we get a major version update on a dataset, it would be useful to be able to assess what has changed in order to determine what to obsolete. This could be achieved via a function that wraps this one (which should be the subject of a separate ticket).

@Clare72
Copy link
Contributor

Clare72 commented Nov 24, 2022

I can't find an existing property that fits what we want - shall we make this a neo property <http://n2o.neo/property/obsolete_type> or add something to vfb_ext?
Also would it make most sense for this to be a method on the kb_owl_edge_writer class?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants