Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve kb_tests.py #267

Open
dosumis opened this issue Jul 13, 2022 · 1 comment
Open

Refactor and improve kb_tests.py #267

dosumis opened this issue Jul 13, 2022 · 1 comment
Assignees

Comments

@dosumis
Copy link
Member

dosumis commented Jul 13, 2022

  1. Currently this script runs against all datasets (or all with schema = ['image']). We need t be able to run against single datasets, specified in Command Line arg, as well as against all. It should be easy to do this by refactoring to runner a script (with argparse) + a separate file of functions.

  2. Logging -> reports is a bit of an ad hoc mess right now. Should be refactored to nicely structured JSON with standard keys for test name, number of failing inds + list of failing inds.

With these improvements in place, we should look at running in Jenkins - coupled to curation loading (dataset names can be extracted from curation record YAML files)

@hkir-dev
Copy link
Contributor

hkir-dev commented Aug 3, 2022

PR created #270

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants