Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synonym reference edges with type = pub #232

Open
dosumis opened this issue Nov 10, 2020 · 2 comments
Open

synonym reference edges with type = pub #232

dosumis opened this issue Nov 10, 2020 · 2 comments
Assignees

Comments

@dosumis
Copy link
Member

dosumis commented Nov 10, 2020

Large numbers of synonym edge links to pubs are ending up typ=def.

This is happening because annotation axiom addition uses the simple wrapper = merge. This overwrites 'typ={some synonym type}' with typ='def' every time a definition is processed after a synonym.

Potential solution:

  • typ --> list to which items are appended. So an edge can be both syn and def. Note def values are handled separately on node.
@dosumis
Copy link
Member Author

dosumis commented Nov 10, 2020

CC @Robbie1977

@dosumis
Copy link
Member Author

dosumis commented Nov 10, 2020

From discussion with Robbie:

  1. Multiple types on edges isn't safe. What if the same paper has different types of synonym?
  2. Proposed solution (from discussion with Robbie): Use bespoke edge types - exact_synonym_reference, definition_reference etc. Where one pub has more than one synonym of a particular type these can just be listed under value.

@dosumis dosumis self-assigned this Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant