Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order Number is not sequence #148

Closed
tonhuynh opened this issue Feb 26, 2020 · 2 comments
Closed

Order Number is not sequence #148

tonhuynh opened this issue Feb 26, 2020 · 2 comments

Comments

@tonhuynh
Copy link

Our server host on Azure with 2 instances, and our order-number field hasn't been sequence.

  • Order number template: CO{0:yyMMdd}-{1:D5}

Version info:

  • Browser version:
  • Platform version: 2.13.44
  • Module version: 2.25.18

Expected behavior

OrderNumber must be sequence.

Actual behavior

Order number wasn't

Steps to reproduce

  1. Commerce Manager: fixed 2 instances
  2. Login to Storefront and create orders with multiple users, browsers as the same time.

Reason:

  1. using InMemorySequenceList won't share memory between commerce instances.
  2. When we turn Off Cookies on Storefront, this issue will happen.
@yecli
Copy link
Contributor

yecli commented Feb 26, 2020

Current implementation guarantees number uniqueness (in case of a date part presented in the template) and increasing sequence in case of one platform instance.
The strict increasing sequence with customization will be implemented at #146 (it is in progress now).
It will be done in v3 first.

@yecli yecli closed this as completed Feb 26, 2020
@tonhuynh
Copy link
Author

Good to know that. Thanks @yecli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants